Repository navigation
fix(android): build on Firebase BoM 35 and require minSdk 24 - #18782
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
8727276 to
0550a37
Compare
0550a37 to
25b96aa
Compare
…er deps BoM 35 no longer manages ML Model Downloader, and Firestore 27 publishes test libraries as runtime dependencies that Jetifier cannot transform.
BoM 35 raises the Firebase libraries to API 24. Plugin configs and example apps that still pinned 23 would fail to compile against those libraries.
Flutter 3.27 through 3.32 still default minSdk to 21. Those example apps would fail manifest merger against BoM 35 libraries.
25b96aa to
cf8e4c5
Compare
Description
Stacked on #18767. The base branch is
feat/bump-android-sdk-35.0.0, notmain, because these changes only compile against the Firebase Android BoM 35 pin. Merge this into the bump branch first; that turns #18767 green, and then it merges intomain.firebase-ml-modeldownloader, so the plugin now pins it explicitly at 26.1.1, the version BoM 34.19.0 resolved. It will no longer follow BoM bumps. Firestore 27.0.0 publishesmockito-core,junit,truthandjackson-databindas runtime dependencies; Mockito pulls byte-buddy 1.17.7, which Jetifier cannot transform, so the Firestore plugin excludes them.flutter.minSdkVersionto 21, so example apps that follow it now floor at 24 to pass manifest merger.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Apps must use Android minSdk 24 or higher. The breaking-change marker for the release lives on the title of #18767, because this pull request is squashed into that branch.
Test plan