Skip to content

fix(android): build on Firebase BoM 35 and require minSdk 24 - #18782

Merged
SelaseKay merged 3 commits into
mainfrom
fix/bump-android-sdk-35.0.0-ci
Oct 13, 2026
Merged

SelaseKay merged 3 commits into
mainfrom
fix/bump-android-sdk-35.0.0-ci

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Stacked on #18767. The base branch is feat/bump-android-sdk-35.0.0, not main, because these changes only compile against the Firebase Android BoM 35 pin. Merge this into the bump branch first; that turns #18767 green, and then it merges into main.

  • Firestore and ML Model Downloader dependencies. BoM 35 no longer manages firebase-ml-modeldownloader, so the plugin now pins it explicitly at 26.1.1, the version BoM 34.19.0 resolved. It will no longer follow BoM bumps. Firestore 27.0.0 publishes mockito-core, junit, truth and jackson-databind as runtime dependencies; Mockito pulls byte-buddy 1.17.7, which Jetifier cannot transform, so the Firestore plugin excludes them.
  • minSdk 24. BoM 35 raises the Firebase libraries to API 24. Plugin configs and example apps that still pinned 23 now require 24.
  • Example apps. Flutter 3.27 through 3.32 still default flutter.minSdkVersion to 21, so example apps that follow it now floor at 24 to pass manifest merger.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Apps must use Android minSdk 24 or higher. The breaking-change marker for the release lives on the title of #18767, because this pull request is squashed into that branch.

Test plan

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay added this pull request to stack #18785 October 12, 2026 10:38
@SelaseKay
SelaseKay force-pushed the fix/bump-android-sdk-35.0.0-ci branch 2 times, most recently from 8727276 to 0550a37 Compare October 13, 2026 08:50
Base automatically changed from feat/bump-android-sdk-35.0.0 to main October 13, 2026 09:22
@SelaseKay
SelaseKay force-pushed the fix/bump-android-sdk-35.0.0-ci branch from 0550a37 to 25b96aa Compare October 13, 2026 09:22
…er deps

BoM 35 no longer manages ML Model Downloader, and Firestore 27 publishes test libraries as runtime dependencies that Jetifier cannot transform.
BoM 35 raises the Firebase libraries to API 24. Plugin configs and example apps that still pinned 23 would fail to compile against those libraries.
Flutter 3.27 through 3.32 still default minSdk to 21. Those example apps would fail manifest merger against BoM 35 libraries.
@SelaseKay
SelaseKay force-pushed the fix/bump-android-sdk-35.0.0-ci branch from 25b96aa to cf8e4c5 Compare October 13, 2026 10:06
@SelaseKay
SelaseKay merged commit 7555707 into main Oct 13, 2026
112 of 113 checks passed
@SelaseKay
SelaseKay deleted the fix/bump-android-sdk-35.0.0-ci branch October 13, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants