Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a customizable styling and typography system for the authentication flow, including AuthCTAButtonStyle for primary buttons, AuthTextFieldStyle for text fields, and AuthTypography for custom font families. The feedback highlights three key issues: a double-scaling bug in AuthTypography when resolving custom fonts with Dynamic Type, a regression in AuthCTAButtonModifier where passing a nil background color clears the inherited environment tint, and a visual regression in EmailAuthView where the blue color of the switch-auth-flow action label was accidentally removed.
….4 (#1405) Bumps [github.com/google/googleutilities](https://github.com/google/GoogleUtilities) from 8.1.3 to 8.1.4. - [Release notes](https://github.com/google/GoogleUtilities/releases) - [Commits](google/GoogleUtilities@8.1.3...8.1.4) --- updated-dependencies: - dependency-name: github.com/google/googleutilities dependency-version: 8.1.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…on the auth-flow switch label
…theming of text fields and CTA buttons
…se remaining unstyled-text gaps across the auth flow
- CTA labels fall back to body, not headline, so unthemed buttons keep their weight - Provider buttons keep the system font; Delete Account stays red under a CTA theme - Make the no-argument authCTAButtonStyle() and AuthFontModifier internal - Rename AuthTypography.fontFamily to fontName - Re-apply the custom font to verification code boxes on update - Move MFAResolutionView onto VerificationCodeInputField and shared button styles
russellwheatley
left a comment
There was a problem hiding this comment.
LGTM. Could you add the EmailAuthView weight changes (semibold to medium on the sign up label, medium on the password recovery label) to the intentional default appearance change line in the description? Thanks 🙏
Adds environment-driven theming for the SwiftUI auth flow's text fields, CTA buttons and typography. Unset values keep today's exact appearance. First of the PRs splitting up #1400.
Changes
AuthTextFieldStyle,AuthCTAButtonStyleandAuthTypography, each set with aViewmodifier and carried through the environment so they reach pushed screens inside the auth sheet..buttonStyle(.borderedProminent)and.font(_:)calls across the auth screens with.authCTAButtonStyle()and.authFont(_:weight:). Brand-styled provider buttons and the Delete Account button are unchanged.AuthTypographyto typed text andAuthTextFieldStyleto the verification code boxes, not justAuthTextField.MFAResolutionViewontoVerificationCodeInputFieldand the shared button styles, so theming reaches it like the other MFA screens. This is an intentional default appearance change: its buttons now match the other MFA screens instead of hand-rolled blue and grey rectangles..font,.buttonBorderShapeor.tintstill reaches CTA buttons and text that had no explicit font before.FirebaseAuthUIComponentsfromFirebaseAuthSwiftUI. It is not a library product, soAuthTextFieldStyleandAuthTypographywere otherwise unreachable fromimport FirebaseAuthSwiftUI.API Usage
Preview
Maintainer note: Fixes internal CPRN-515