Repository navigation
feat(message): document and test attachments and previews on message update - #908
Draft
symphony-enrico wants to merge 1 commit into
Draft
symphony-enrico wants to merge 1 commit into
symphony-enrico wants to merge 1 commit into
Conversation
…update - Update javadoc in MessageService and OboMessageService indicating attachments and previews are supported only starting from SBE v24.1 - Add unit tests in MessageServiceTest verifying update requests with single attachment + preview, multiple attachments, text-only, and OBO - Add documentation and code snippet in docs/message.md - Archive OpenSpec change update-message-attachments and sync delta specs to main specs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies and validates support for file attachments and previews when updating existing messages via
MessageServiceandOboMessageService.While
MessageService.update(...)has forwarded attachments and previews throughgetForm(Message)since SBE v24.1, the javadocs previously stated that attachments were not yet supported, and no automated tests or documentation examples verified the functionality.Key changes:
MessageService.java&OboMessageService.java:update(...)overloads to clarify that attachments and previews are supported only starting from SBE v24.1.MessageServiceTest.java:captureUpdateFormParamstest helper to inspect multipart form parts and headers dispatched to the API client.docs/message.md:openspec/specs/message-update-attachments/spec.md.openspec/changes/archive/2026-10-06-update-message-attachments/.Dependencies
None.
Checklist