Repository navigation
fix(linux-deploy): skip all glibc libraries when bundling - #375
Conversation
On Arch Linux, ldd reports glibc as /usr/lib/libc.so.6. The copy_ldd_deps() skip list only matched multiarch (/usr/lib/*/) and /usr/lib64/ paths, so libc.so.6 and libm.so.6 were bundled into the runtime directory while the loader was not. With RPATH $ORIGIN the game then mixes the bundled libc with the host loader, which breaks startup after a host glibc update or on another machine. The other glibc libraries (libmvec, libresolv, libutil, libanl, libnsl.so.1, libnss_*, libthread_db and a few more) were missing from the skip list entirely, so they were bundled on every distro when a dependency needed them, for example libmvec.so.1 via libx265. Add /usr/lib/<lib>.so.* patterns for libc, libm, libpthread, librt and libdl, and */<lib> patterns for the remaining glibc libraries, in the deploy, bundle and AppImage scripts for both Zero Hour and Generals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title follows Conventional Commits with the valid type "fix", the scope "linux-deploy", and a concise description that matches the glibc exclusion changes. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Platform Isolation | |
The pull request changes only six Linux deployment/AppImage shell scripts and one worklog. The authoritative diff contains no changes under Generals/, GeneralsMD/, or Core/GameEngine/. The added… |
| Cross-Platform Determinism | |
PASS: The pull request changes only Linux shell bundling scripts and a worklog. It does not change simulation/game logic, math operations, divisions, or integer casts. The WWMath and NaN/Inf requireme… |
| Openal / Miniaudio Parity | |
PASS: The pull request changes only Linux bundling scripts and a worklog. The authoritative diff contains no OpenAL or MiniAudio audio modifications, so there is no audio change that requires parity r… |
| Conventional Commit Standards | |
The reviewed commit subject is fix(linux-deploy): skip all glibc libraries when bundling. It follows Conventional Commits syntax and contains no @ character. The pull request title matches the sub… |
| No Hardcoded Local Paths / Sensitive Info | |
PASS: The pull request adds only standard Linux library match patterns (/usr/lib/... and wildcard library names) and documentation describing those paths. The added $ORIGIN token is a standard ELF… |
| Ngmp Protocol Integrity | |
PASS: The pull request changes only seven Linux bundling/deployment shell scripts and one worklog entry. The diff adds glibc skip patterns inside copy_ldd_deps(); it does not modify GeneralsOnline/, N… |
Full details: Platform Isolation
-
Explanation
The pull request changes only six Linux deployment/AppImage shell scripts and one worklog. The authoritative diff contains no changes under
Generals/,GeneralsMD/, orCore/GameEngine/. The added code is Linux dependency path filtering incopy_ldd_deps(), not Win32, Cocoa, or raw POSIX API usage in game logic. Platform behavior remains isolated from the specified game-logic directories.
Full details: Cross-Platform Determinism
-
Explanation
PASS: The pull request changes only Linux shell bundling scripts and a worklog. It does not change simulation/game logic, math operations, divisions, or integer casts. The WWMath and NaN/Inf requirements are therefore not applicable to this diff.
Full details: Openal / Miniaudio Parity
-
Explanation
PASS: The pull request changes only Linux bundling scripts and a worklog. The authoritative diff contains no OpenAL or MiniAudio audio modifications, so there is no audio change that requires parity review.
Full details: Conventional Commit Standards
-
Explanation
The reviewed commit subject is
fix(linux-deploy): skip all glibc libraries when bundling. It follows Conventional Commits syntax and contains no@character. The pull request title matches the subject.
Full details: No Hardcoded Local Paths / Sensitive Info
-
Explanation
PASS: The pull request adds only standard Linux library match patterns (
/usr/lib/...and wildcard library names) and documentation describing those paths. The added$ORIGINtoken is a standard ELF runtime variable, not a private environment variable. The reviewed additions contain no personal home paths (/Users,/home), workspace paths, internal URLs, or sensitive data.
Full details: Ngmp Protocol Integrity
-
Explanation
PASS: The pull request changes only seven Linux bundling/deployment shell scripts and one worklog entry. The diff adds glibc skip patterns inside copy_ldd_deps(); it does not modify GeneralsOnline/, NextGenMP/, cmake/ngmp.cmake, NGMP-related C++ files, UI event handling, loading-screen ticking, transport code, WebSocket/REST protocol code, or platform networking APIs. The existing deployment logic still copies GameNetworkingSockets unchanged.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Six scripts scan the paths,
Glibc libraries skip the copy,
Bundles keep their course,
AppImages follow suit,
The worklog marks the change.
Comment @coderabbitai help to get the list of available commands.
2 participants
On Arch Linux, ldd reports glibc as /usr/lib/libc.so.6. The copy_ldd_deps() skip list only matched multiarch (/usr/lib/*/) and /usr/lib64/ paths, so libc.so.6 and libm.so.6 were bundled into the runtime directory while the loader was not. With RPATH $ORIGIN the game then mixes the bundled libc with the host loader, which breaks startup after a host glibc update or on another machine.
The other glibc libraries (libmvec, libresolv, libutil, libanl, libnsl.so.1, libnss_*, libthread_db and a few more) were missing from the skip list entirely, so they were bundled on every distro when a dependency needed them, for example libmvec.so.1 via libx265.
Add /usr/lib/.so.* patterns for libc, libm, libpthread, librt and libdl, and */ patterns for the remaining glibc libraries, in the deploy, bundle and AppImage scripts for both Zero Hour and Generals.
Summary by CodeRabbit