Repository navigation
Retry Hashdown downloads and write them atomically - #22
Merged
Merged
Conversation
Retry network errors and HTTP 5xx responses up to three times with 1, 2 and 4 second waits; a 404 still returns False at once and other 4xx errors are raised. Give each connection a 60-second timeout, and download to a temporary file that is renamed into place only when complete, so an interrupted download cannot leave a partial file that a later trust_local_files run would accept. Add tests with a fake urlopen covering retries, give-up, 404 and 4xx handling, and interrupted downloads.
CarlKCarlK
force-pushed
the
download-retries
branch
from
November 14, 2026 17:30
ed94db8 to
8b6f31c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashdown._get_large_file(behindexample_file, and FaST-LMM's sample data) made oneurlopencall with no timeout or retry, writing straight to the final path. Today a macOS CI job failed on a single HTTP 503 while fetching sample files.Falseimmediately; other 4xx errors are raised without retry..partfile andos.replaceit into place only when complete; an interrupted download leaves the previous file (if any) untouched and no partial file behind.test_hashdown_retry.py(fakeurlopen, no network) registered in the canonical suite.