Conversation
- Faker::Company#calculate_gst_checksum: never called; indian_gst_number computes its checksum inline (both added in 205bc52). - Faker::Types#titleize: only called by its own test through `send` since it was added (28eaeb6); the test goes with it. - TestFakerTypes::TestModule: empty and unreferenced since 28eaeb6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because these private helpers have no callers:
Faker::Company#calculate_gst_checksumhas never been called.indian_gst_numbercomputes the same checksum inline. Both came in with 205bc52.Faker::Types#titleizehas only ever been called by its own test, throughsend, since it was added in 28eaeb6. The test is removed with it.TestFakerTypes::TestModuleis empty and unreferenced, also since 28eaeb6.This is a pure deletion with no behavior change.
Additional information
A repo-wide search finds no other mention of any of the three.
rake testand rubocop pass.Checklist
[Fix #issue-number]Found with trekr