Repository navigation
Conversation
Summary:
# Why
Saving a model configuration with BoTorch's native `Log10` input transform fails because the shared input-transform registry does not recognize the class.
# Changes
- Register BoTorch's native `Log10` input transform in the existing serialization registry.
- Add a JSON round-trip test that preserves the transform class and its options in a `ModelConfig`.
# Examples
Input:
```python
config = ModelConfig(
input_transform_classes=[Log10],
input_transform_options={"Log10": {"indices": [1]}},
)
```
## Before
```python
object_to_json(config)
# ValueError: Log10 is not in the Type[InputTransform] registry
```
## After
```python
restored = object_from_json(json.loads(json.dumps(object_to_json(config))))
assert restored == config
```
Differential Revision: D126825222
meta-cla
Bot
added
the
CLA Signed
|
@ltiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126825222. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5308 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 621 621
Lines 71095 71099 +4
=======================================
+ Hits 68679 68683 +4
Misses 2416 2416 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 8a07d83. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Why
Saving a model configuration with BoTorch's native
Log10input transform fails because the shared input-transform registry does not recognize the class.Changes
Log10input transform in the existing serialization registry.ModelConfig.Examples
Input:
Before
After
Differential Revision: D126825222