Repository navigation
fix(python): settle cancelled tasks awaited by async workflows - #5064
Merged
Merged
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python
Async.AwaitTaskletsasyncio.CancelledErrorescape its completion callback because that exception derives fromBaseException. A cancelled task can therefore leave its waiting workflow unsettled. The existing cancellation test returned throughAsync.StartImmediatebefore its assertion ran, closing its event loop before a background cancellation timer fired and producing a thread warning during a later test.Compile
Async.AwaitTaskto a newawait_task_with_cancellationentry point that reports native task cancellation asTaskCanceledExceptionthrough the error continuation, matching .NET. Add the Python exception type and compiler mapping, including message and inner-exception support. Preserve the legacyawait_taskentry point for existing Python consumers; newly generated code requires the runtime containing the new entry point.Replace the cancellation test with an awaited test that uses a child-entry handshake and checks the error outcome on both .NET and Python. Add native coverage for tasks cancelled before and during the wait, plus an F# regression for the exception type and payload.