Repository navigation
fix(python): avoid name collisions in nested tuple matches - #5027
Merged
Merged
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
dbrattli
marked this pull request as ready for review
September 30, 2026 17:50
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nested tuple matches can reuse an outer match's Python
match_valuebinding, causing union-field access to read from the inner scrutinee and raiseAttributeError. The same collision affects captured fields in closures and user bindings namedmatch_value.Fixes #5026.
How
Convert generated identifiers to Python naming before checking and reserving unique names. Add three regression tests covering nested matches, closures, and user bindings, including fallback branches and repeated closure calls.
Validation
./build.sh test python --force-fable-library --type-check: 2,395 .NET tests and 2,485 Python tests passed with a freshly generated runtime.main: 34 existing errors and 45 warnings, with no added errors and no errors in the regression file.git diff --checkpassed.