Skip to content

fix(js/python/dart): handle Rune in non-Rust builtin matches - #5024

Merged
dbrattli merged 1 commit into
mainfrom
fix/rune-exhaustive-replacements
Sep 30, 2026
Merged

dbrattli merged 1 commit into
mainfrom
fix/rune-exhaustive-replacements

Conversation

@dbrattli

Copy link
Copy Markdown
Collaborator

Adding BclRune for Rust support in #4997 left six incomplete matches in the JavaScript, Python, and Dart replacement modules. These produce FS0025 warnings during compiler builds and analyzer CI, including on unrelated PRs.

Explicitly reject Rune core-module lookup through the existing FableError path and return None from tryType on those targets, which have no Rune replacement implementation. Keep the matches exhaustive so future builtin additions still produce compiler warnings.

Validation:

  • Release build of Fable.Transforms.fsproj with -warnaserror:25: passed, zero warnings or errors.
  • Fantomas check on all three changed files: passed.
  • git diff --check: passed.

@dbrattli dbrattli changed the title fix(transforms): handle Rune in non-Rust builtin matches fix(all): handle Rune in non-Rust builtin matches Sep 30, 2026
@dbrattli
dbrattli marked this pull request as ready for review September 30, 2026 16:17
@dbrattli dbrattli changed the title fix(all): handle Rune in non-Rust builtin matches fix(js/python/dart): handle Rune in non-Rust builtin matches Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Python Type Checking Results (Pyright)

Metric Value
Total errors 34
Files with errors 4
Excluded files 4
New errors ✅ No
Excluded files with errors (4 files)

These files have known type errors and are excluded from CI. Remove from pyrightconfig.ci.json as errors are fixed.

File Errors Status
temp/tests/Python/test_hash_set.py 18 Excluded
temp/tests/Python/test_applicative.py 12 Excluded
temp/tests/Python/test_nested_and_recursive_pattern.py 2 Excluded
temp/tests/Python/fable_modules/thoth_json_python/encode.py 2 Excluded

@dbrattli
dbrattli merged commit 79bed98 into main Sep 30, 2026
59 of 60 checks passed
@dbrattli
dbrattli deleted the fix/rune-exhaustive-replacements branch September 30, 2026 16:35
@ncave

ncave commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

@dbrattli Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants