Repository navigation
fix(js/python/dart): handle Rune in non-Rust builtin matches - #5024
Merged
Merged
Conversation
dbrattli
marked this pull request as ready for review
September 30, 2026 16:17
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
Collaborator
|
@dbrattli Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
BclRunefor Rust support in #4997 left six incomplete matches in the JavaScript, Python, and Dart replacement modules. These produce FS0025 warnings during compiler builds and analyzer CI, including on unrelated PRs.Explicitly reject Rune core-module lookup through the existing
FableErrorpath and returnNonefromtryTypeon those targets, which have no Rune replacement implementation. Keep the matches exhaustive so future builtin additions still produce compiler warnings.Validation:
Fable.Transforms.fsprojwith-warnaserror:25: passed, zero warnings or errors.git diff --check: passed.