Repository navigation
fix(js/ts): endsWith regression for empty pattern with non-ordinal comparison - #4745
Merged
MangelMaxime merged 4 commits intoJul 9, 2026
Merged
Conversation
dbrattli
changed the title
…mparison
str.slice(-pattern.length) becomes slice(-0) === slice(0) (the whole
string) when pattern is empty, so EndsWith("") returned false for
culture/ignore-case comparisons. .NET returns true (every string ends
with ""). Use slice(str.length - pattern.length) instead.
MangelMaxime
force-pushed
the
fix-string-endswith-empty
branch
from
July 9, 2026 18:46
a5b73f8 to
9d456d5
Compare
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str.slice(-pattern.length) becomes slice(-0) === slice(0) (the whole string) when pattern is empty, so EndsWith("") returned false for culture/ignore-case comparisons. .NET returns true (every string ends with ""). Use slice(str.length - pattern.length) instead.
(split from #4738)