Repository navigation
chore: pin mockery and golangci-lint to Go 1.27-compatible versions - #3470
Conversation
- Pin mockery to v3.8.1 in `just mock-gen` (was @latest). Older v3.4.0 fails to load packages under Go 1.27 ("package context without types"). - Pin golangci-lint to v2.14.0 in CI (was latest), so lint results don't change underneath PRs when a new release ships. - Remove a redundant loop variable copy in pkg/config/yaml.go flagged by copyloopvar in golangci-lint v2.14.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The lint and YAML changes show no concrete regression. Mock generation with the pinned version remains unverified, but no failure is established. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the main change: pinning mockery and golangci-lint to versions compatible with Go 1.27. It is concise and follows the repository's semantic commit format. |
| Description check | |
The description includes the required Overview section and provides clear context, rationale, changes, testing results, and an explicit out-of-scope known issue. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3470 +/- ##
==========================================
- Coverage 69.54% 69.53% -0.02%
==========================================
Files 121 121
Lines 12006 12002 -4
==========================================
- Hits 8350 8345 -5
- Misses 3656 3657 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Overview
CI already builds with Go 1.27.0. Locally, older tool builds break under 1.27:
internal error: package "context" without types was imported from ...file requires newer Go version go1.27Changes
just mock-gen: pin mockery@latest→@v3.8.1, which works under Go 1.27.latest→v2.14.0(built with go1.27). Withlatest, lint results could change on a PR just because a new release came out.pkg/config/yaml.go: remove the redundantfield := fieldthatcopyloopvarflags in v2.14.0. It was introduced by the recentgo fix ./...commit, and withlatestit would have failed the next PR that touched Go files.Known issue (not addressed here)
just mock-gendoesn't reproduce the committed mocks, with any mockery version. Several generated mocks were edited by hand:test/mocks/execution.go:ExecuteTxsaccepts a[]bytereturn as backward compat, andGetExecutionInfohas a default.test/mocks/da.go:SupportsSubscribeis not on theClientinterface.Regenerating the mocks today breaks compilation in
block/internal/executingtests. Fixing that means moving those behaviours into test helpers and then regenerating. That's a separate PR.Testing
golangci-lint v2.14.0 run ./...: 0 issues.go test ./pkg/config/...passes.Summary by CodeRabbit