Repository navigation
bugc: reject == and != on arrays and structs - #397
Merged
Merged
Conversation
As in Solidity, `==` and `!=` on an array (fixed or dynamic), a struct or a mapping are now type errors. Before, an array or struct in memory, or a struct copied from storage, compared by its address in memory, so equal contents in two places were unequal, and an array in storage failed in IR generation. Bytes and strings still compare by contents.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in Solidity,
==and!=on an array (fixed or dynamic, in memory or in storage), a struct or a mapping are now type errors ("Cannot compare "), the same diagnostic that bytes and strings in calldata already give.Before, an array or struct in memory, or a struct copied from storage, compared by its address in memory, so equal contents in two places were unequal; an array in storage failed in IR generation ("cannot copy ... to or from storage"). Comparing contents is not planned. Dynamic bytes and strings keep comparing by contents (#391), and elementary types are unchanged.
No example uses these comparisons: bytecode for every example that compiles (all but the
@wipones), at O0 through O3, is the same as on main.