Repository navigation
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets an app on React 19 and shiki 3 install and type-check
@ethdebug/programs-reactand@ethdebug/pointers-react. Thereactandreact-dompeer ranges become^18.0.0 || ^19.0.0, and programs-react'sshiki,@shikijs/langsand@shikijs/themesranges become^2.5.0 || ^3.0.0. The monorepo itself, Docusaurus included, stays on React 18 and shiki 2.Components annotated the global
JSX.Element, which@types/react19 removes; they now useReact.JSX.Element, which both versions define (bugc-react too, though its peers stay on React 18 becausereact-flow-rendererv10 only supports up to 18).New
yarn check:react-consumers(and a CI job) packs the packages, installs them with plainnpm installinto a React 18 + shiki 2.5 and a React 19 + shiki 3 project, type-checks each withskipLibCheck: false, and bundles the highlighter without code splitting to assert it stays under 400 KB gzipped (about 285 KB now). That guards against importing every grammar and theme throughshiki/langsandshiki/themes, which is the only route shiki 2.5 offers besides the per-package imports we keep.The shiki ranges can resolve to different majors for
shikiand the grammar and theme packages. The consumer check installs both mixes (shiki 2.5 with 3.x grammars and themes, and the reverse) and highlights Solidity with the theme in each, so the mix is covered.