Repository navigation
ci: run conformance on main and weekly; soldb v0.4.0 - #338
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solc + soldb conformance job ran only on pull requests that touch certain paths, so drift in solc's develop branch or in soldb went unnoticed until an unrelated PR failed. This also runs it on pushes to main (same paths filter) and every Monday at 06:00 UTC, and it moves the default soldb ref from v0.3.0 to v0.4.0. Concurrency is now grouped by event, and only pull request runs cancel each other, so a scheduled run never cancels a PR run.
SolDB v0.4.0 prints its breakpoint hit line as
Breakpoint #1 hit at step 88, Counter.sol:8, without the trailing, PC 558that v0.3.0 added. The source-line breakpoint check used that, PCsuffix to see where the debugger stopped, so it now matches the target afterhit at step N,instead.