Repository navigation
ci: cancel superseded pull request runs - #1315
Open
NopeCharon wants to merge 1 commit into
Open
NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
None of the workflows that run on pull requests set a concurrency group, so pushing a new commit to a pull request left the runs for the previous commit going alongside the new ones. For test and upgrade that means a full set of image builds and e2e test matrices burning runner time for a commit nobody will look at. Give test, upgrade, deploy_docs and dep-review a concurrency group keyed on the pull request number with cancel-in-progress, so a new push cancels the run it replaces. Events without a pull request (pushes, including to main, and the docs deployment) fall back to the run ID, so each of those keeps a group of its own and is never queued behind or cancelled by another run. Fixes eraser-dev#857 Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
NopeCharon
requested review from
ashnamehrotra,
pmengelbert and
sozercan
as code owners
October 26, 2026 05:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
None of the workflows that run on pull requests set
concurrency. When a new commit is pushed to a PR, the runs for the old commit keep going next to the new ones. Fortestandupgrade, that's a full set of image builds and e2e matrix jobs spent on a commit nobody will look at.This adds a workflow-level concurrency group to
test,upgrade,deploy_docsanddep-review:main, and the docs deployment) fall back togithub.run_id. Each of those gets its own group, so it is never queued behind or cancelled by another run. Post-mergemainruns and GitHub Pages deploys behave exactly as before.The reusable workflows (
build-id,e2e-build,e2e-test) are left alone because they run inside the caller's group. Workflows that don't run on pull requests are unchanged.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #857
Special notes for your reviewer:
The four changed workflows pass
actionlintv1.7.7.