Repository navigation
Conversation
…s very confusing and counter-intuitive. This does not alter the functionality. This includes changing the default value of 'rawsupport' from 0 to 1. Notably test_db.py does not set 'raw' so relies on the default value. Removed pydevsupComSpec which was not used anywhere. Changed the names of init_record and init_record2 to init_record_in and init_record_out for greater clarity. Changed the names of process_record and process_record2 to process_record_out and process_record_in for greater clarity. Added some more detailed test logic to test_db.py. Most importantly, added clearing of the UDF field within ptable.py to ensure that records without VAL set and without other means of clearing UDF do not retain the UDF alarm state.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inverted the logic of 'raw' which previously meant 'not raw'. This was very confusing and counter-intuitive.
This does not alter the functionality.
This includes changing the default value of 'rawsupport' from 0 to 1. Notably test_db.py does not set 'raw' so relies on the default value.
Removed pydevsupComSpec which was not used anywhere.
Changed the names of init_record and init_record2 to init_record_in and init_record_out for greater clarity. Changed the names of process_record and process_record2 to process_record_out and process_record_in for greater clarity.
Added some more detailed test logic to test_db.py.
Most importantly, added clearing of the UDF field within ptable.py to ensure that records without VAL set and without other means of clearing UDF do not retain the UDF alarm state.