Skip to content

fix: do not echo scan result to the log when output_file is set - #106

Draft
tsaekao-endor wants to merge 1 commit into
mainfrom
fix/output-file-suppress-log-echo
Draft

tsaekao-endor wants to merge 1 commit into
mainfrom
fix/output-file-suppress-log-echo

Conversation

@tsaekao-endor

Copy link
Copy Markdown

When output_file is set, the action no longer prints the scan result to the workflow log. The result still goes to the file. Progress and error messages still appear in the log. Behavior without output_file does not change.

Closes #105

Details:

  • src/scan.ts: discard the stdout echo with a no-op outStream, and echo stderr through a listener. silent: true is not used because it also hides stderr.
  • action.yml and README.md: state the new behavior. dist/ is rebuilt.
  • Checked with a fake endorctl: the result is captured, stdout is empty, and stderr is kept. yarn run build, format, lint, package, and test pass. I did not run yarn run license.
  • Not tested: a full workflow run against a real scan.

To try it before merge: uses: endorlabs/github-action@fix/output-file-suppress-log-echo with output_file set.


🥷 harness v1.7.1201-337-gec74492ae2 · sonnet-5-5 · default · @main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

output_file still prints the full scan result JSON to the workflow log

1 participant