Repository navigation
fix: do not echo scan result to the log when output_file is set - #106
Draft
tsaekao-endor wants to merge 1 commit into
Draft
tsaekao-endor wants to merge 1 commit into
tsaekao-endor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
output_fileis set, the action no longer prints the scan result to the workflow log. The result still goes to the file. Progress and error messages still appear in the log. Behavior withoutoutput_filedoes not change.Closes #105
Details:
src/scan.ts: discard the stdout echo with a no-opoutStream, and echo stderr through a listener.silent: trueis not used because it also hides stderr.action.ymlandREADME.md: state the new behavior.dist/is rebuilt.yarn run build,format,lint,package, andtestpass. I did not runyarn run license.To try it before merge:
uses: endorlabs/github-action@fix/output-file-suppress-log-echowithoutput_fileset.🥷 harness
v1.7.1201-337-gec74492ae2·sonnet-5-5·default·@main