Repository navigation
WebGL: stop CancelConnection() throwing on an open socket - #108
Merged
Merged
Conversation
Pull requests from branches in this repo get the API key, so every PR run packed and pushed the current version; only --skip-duplicate kept one from publishing. Assisted-by: Claude Opus 5.5
Browsers only accept 1000 or 3000-4999 in close(), so closing with 1006 threw; Colyseus' Connection.Drop() threw with it. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
A pull request that bumps the version ran the UPM branch update and the GitHub release from the PR, before it was merged. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CancelConnection()on an open WebGL socket closed it with 1006, which browsers reject inclose(), so it threw (and Colyseus'Connection.Drop()with it). It now closes with 1000 and still reportsAbnormal(1006) toOnClose, like the other platforms.The first commit restores the push-only guard on the NuGet publish job. With it commented out, a pull request from a branch in this repo ran
dotnet nuget pushwith the API key; only--skip-duplicatekept the PR from publishing. Because a PR runs the workflow from its own branch, this PR's CI already runs with the guard.Changelog entry under
## 2.0.8. The version isn't bumped, so merging publishes nothing.Not tested in a browser yet.
🤖 Generated with Claude Code