Repository navigation
fix: Require patched certifi for GHSA-6q48-6c7w-9gw2 - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @wagner
🔴 Review tier: HIGH — human review required
What / why
certifi>=2026.10.19so SDK customer installations cannot resolve an affected certificate bundle.uv lock --upgrade-package certifi: certifi changes from 2025.4.26 to 2026.10.19. All other locked package records are unchanged; unrelated resolver metadata churn was removed.How tested
uv sync --lockedpassed.uv run --locked coverage run -m pytest --junitxml=report.xml: 132 passed; 91% coverage.uv run --locked ruff check asknews_sdk: passed.uv build --wheel: passed; inspected wheel metadata to verifyRequires-Dist: certifi>=2026.10.19.git diff --check: passed.Risk / rollback
Updates the TLS CA trust bundle as required by the advisory; endpoints relying on removed trust may stop validating. No workflow changes, version bumps, or feature docs. Human review/merge and PyPI release ownership remain required; no merge, tag, or publish performed. Reverting would restore the vulnerable minimum and should not be done without an alternative mitigation.