Repository navigation
generate: volts / mA flags for the 16-bit form (firmware 3.9.1+) - #36
Merged
Merged
Conversation
Firmware 3.9.1 takes generate in volts on a DAC path (or microamps on the 4-20 mA output), calibrates it and plays it at the DAC's full 16 bits. The new flags send that form. Firmware before 3.9.1 ignores the volts and would play its default full-scale 8-bit waveform, so the CLI reads the pod's caps first and refuses without generate16. --amplitude/--offset stay the 8-bit levels and cannot be mixed with the new flags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with embeddedci-com/benchpod-firmware#52 (firmware 3.9.1) and embeddedci-com/embeddedci-python#38.
benchpod generate --path 3v3 --amplitude-v 1.48 --offset-v 1.65(or--amplitude-ma 4 --offset-ma 12on the 4-20 mA output) sends the calibrated 16-bitgenerate.statusfirst and refuses without thegenerate16cap.--amplitude/--offset(8-bit levels) unchanged; mixing them with the new flags is refused.cliReference.ts+coverage/cli.json) follows after the release.Tests: new
generate16_test.go(volts, mA, refusal on a pod without the cap with nothing sent, flag errors);go test ./...green exceptinternal/fwrefusalslocally, which reads a stale sibling firmware checkout (CI pins it).🤖 Generated with Claude Code