Repository navigation
Fix SystemLimitError in multialias lookups for long aliases - #1286
Merged
Merged
Conversation
Module.concat/1 raises SystemLimitError when the combined module name
exceeds the 255 character atom limit. The multialias branches in the
definition, references and hover providers (`Outer.{Inner}`) called
Module.concat directly, so a long combined alias crashed the request.
Add a private concat_aliases/1 helper that rescues SystemLimitError and
returns nil; the call sites return no result (nil, or [] for references)
in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
SystemLimitErrorcrash in go-to-definition (and the same pattern in hover and references) when the cursor is on a multi-alias segment (Outer.{Inner}) and the combined module name exceeds the 255-character atom limit.Crash report (Elixir 1.18.4, atom shortened):
Changes
providers/definition/locator.ex,providers/references/locator.ex,providers/hover/docs.ex: the threeModule.concatcalls in the multi-alias branch now go through a privateconcat_aliases/1helper that rescuesSystemLimitErrorand returnsnil. Callers skip the lookup onnil(definition and hover returnnil, references returns[]).test/providers/definition/locator_test.exs: regression test with a long combined alias under a multi-alias. Verified it fails withSystemLimitErroron the previous code.Implementation and completion providers do not have this pattern.