Repository navigation
Fix completion crash on plugin suggestions without default_args - #1285
Merged
lukaszsamson merged 1 commit intoOct 18, 2026
Merged
Conversation
Third party ElixirSense-style plugins may emit function/macro suggestions without the optional default_args key, which crashed maybe_reject_derived_functions/3 with a KeyError. Treat a missing key as 0.
lukaszsamson
deleted the
fix-completion-plugin-suggestion-default-args
branch
October 18, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion crashed when a third party plugin returned a function/macro suggestion without the optional
default_argskey:The suggestion has the old ElixirSense plugin shape (
def_arity,args_list,origin, nodefault_args), supplied by a plugin loaded throughElixirSense.Plugin/ElixirLS.LanguageServer.Plugin. It is not emitted bySpark.ElixirSense.Plugin(spark 2.7.8 emits no function suggestions of this shape), so the exact emitting package is unconfirmed.maybe_reject_derived_functions/3now treats a missingdefault_argsas 0. The otherfrom_completion_itemclauses pattern match on their keys and fall through to the catch-all clause, so they do not raise.Adds a test with a fake plugin that emits this shape.