Repository navigation
Bump elixir_sense and fix flaky CI tests - #1280
Merged
Merged
Conversation
Update elixir_sense to a15a1f4b, which includes the SurroundContext
`%var.foo{}` hover crash fix (elixir-lsp/elixir_sense#345) and the
Normalized.Typespec corrupt beam fix (elixir-lsp/elixir_sense#346).
Debug adapter tests swapped the group leader of the global
ElixirLS.DebugAdapter.Output process for a PacketCapture linked to the
test process. The capture died with the test process before on_exit
restored the group leader, so an async request finishing in that window
(e.g. a telemetry event for `evaluate`/`continue`) made Output stop with
`:terminated`. Output is not supervised, so every following test failed
in setup with `Process.info(nil)`. Start the capture unlinked and stop it
in on_exit after the group leader is restored.
The "find implementations of behaviour module" test relied on the order
of `:code.all_loaded/0`; sort the results before matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elixir_sense bump
Updates elixir_sense to
a15a1f4b, picking up:%var.foo{}(inside_dot_to_binding({:local_or_var, _}, _)FunctionClauseError):beam_libraises on a corrupt or half-written.beamFlaky debug adapter tests (seen on Elixir 1.20 / OTP 29)
debugger_test.exsandexunit_formatter_test.exspoint the group leader of the globalElixirLS.DebugAdapter.Outputprocess at aPacketCapturestarted withstart_linkfrom the test process. When the test process exits, the capture dies with it, beforeon_exitrestores the group leader. An async request finishing in that window (e.g. adap_requesttelemetry event forevaluate/continue) makesOutputwrite to a dead group leader and stop with:terminated:Outputis not supervised, so every following test fails in setup:The fix adds an unlinked
PacketCapture.start/1. The tests now use it and stop the capture inon_exitafter the group leader is restored.Order-dependent implementation locator test
find implementations of behaviour modulematched the result list positionally, but the order comes from:code.all_loaded/0and is not deterministic. It failed on master (Elixir 1.20 / OTP 29 / windows). The test now sorts the results before matching.