Repository navigation
Conversation
Pages now deploys on every main push independently of the container build. PRs get a docs build check using the same job. Removes the deploy job from prerelease.yml so it no longer blocks on containers. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Misfiled — this workflow belongs in the docs-playground-release-notes-tagged repo, not docs-builder. |
Contributor
There was a problem hiding this comment.
Approved.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the GitHub Pages deploy from the container build pipeline. Pages now updates on every main push independently, and PRs get a docs build check to catch broken content before merge.
Affects: Automation, Documentation
Prompt summary: The Pages deploy lived inside `prerelease.yml` behind `needs: [build]`, so documentation only updated when the full container build pipeline succeeded. The user wanted a standalone workflow that publishes on main push and also validates docs on PRs.
Why
The `deploy` job in `prerelease.yml` depended on `build` (container publish + attestation). If the container build failed for any reason, GitHub Pages stayed stale. The deploy also silently skipped on PRs, so broken docs only surfaced after merge.
What
New `docs.yml` workflow
Triggers on `push` to `main` and `pull_request`. A single `build` job runs `elastic/docs-builder@main` and uploads the pages artifact; a `deploy` job (main only) deploys it with `actions/deploy-pages`. PRs get the build check without the deploy. The concurrency group prevents concurrent Pages deploys while allowing PR builds to cancel each other.
`prerelease.yml` cleaned up
The `deploy` job is removed. `notify-failure` now only watches `build`. The container build and attestation pipeline is unchanged.