Repository navigation
feat: make the event-native chat timeline the default - #2114
Draft
Douglasymlai wants to merge 1 commit into
Draft
Douglasymlai wants to merge 1 commit into
Douglasymlai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Follows the ChatBox timeline work split out of #1958.
Description
Problem
The new conversation timeline (model switch dividers, the header menu, grouped user messages, inline approvals and the narrative task log) is merged, but it only appears in builds that set
VITE_CHATBOX_EVENT_BUS=true. No checked-in env file sets it, so every normal build, including the installed app, still shows the old conversation view.Cause
isChatEventTimelineEnabled()only returned true for the exact value'true', so an unset variable meant the legacy renderer.Fix
VITE_CHATBOX_EVENT_BUS=false. No env file changes are needed.VITE_CHATBOX_EVENT_BUS=falserestores the legacy conversation view. The value is read at build time, so a rollback is a new build. Sessions whose history has no timeline events yet still fall back to the legacy view, as before.VITE_CHATBOX_EVENT_BUS=false, so the rollback view stays working while both exist.false, the rollback value.truemean on;falsemeans off).Testing Evidence
Automated:
VITE_CHATBOX_EVENT_BUS=false.main.npm run type-check,npm run check:design-tokens, ESLint and Prettier on changed files, andgit diff --check: pass.In the app: not checked yet. Before this is marked ready, a normal dev build (no env changes) should be compared with the old view for:
new, follow-up and stopped Runs;
questions, approvals and plan review;
reopening older Sessions, including ones from before the timeline existed;
model switches, files and the work log;
a build with
VITE_CHATBOX_EVENT_BUS=false, which should show the old view.I have included human-verified testing evidence in this PR.
This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
No frontend/UI changes in this PR.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement