Repository navigation
Conversation
Owner
|
Superseded by #8 — rebased onto current |
Owner
|
Credit where due: the root-cause analysis here was spot on — @LAIM69420 correctly traced the intermittent CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
test_curate_endpoint_requires_auth_and_starts_in_backgroundlaunched the real curation pass withasyncio.create_taskand returned without joining it. The following test fixture could then clear the shared SQLite database while that detached task still held or used another session.The six recent failing CI runs all ended at the next test setup (
test_pause_and_resume_project_via_api) withsqlite3.OperationalError: database is locked.Impact
The endpoint test still proves that curation is scheduled asynchronously, without letting unrelated database and git work escape into the next test.
Validation
pytest tests/integration/test_api.py -q(5 passed)pytest -qthree consecutive times (244 passed each)ruff check tests/integration/test_api.pyUpstream Actions on this draft PR is the final Python 3.12 verification.