Repository navigation
Blink: skip destructuring targets in LineLength - #345
Merged
TomasVotruba merged 1 commit intoNov 11, 2026
Merged
Conversation
Symplify's `LineLengthFixer` only processes array literals: a short destructuring target (`[$a, $b] = ...`, `foreach (... as [...])`) is a different token kind in PHP-CS-Fixer, so the PHP engine never breaks or inlines it. The Go port treated any short `[` as an array and broke over-long destructuring targets across lines. Skip them the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symplify's
LineLengthFixeronly processes array literals: a shortdestructuring target (
[$a, $b] = ...,foreach (... as [...])) is adifferent token kind in PHP-CS-Fixer, so the PHP engine never breaks or
inlines it. The Go port treated any short
[as an array and brokeover-long destructuring targets across lines. Skip them the same way.
🤖 Generated with Claude Code