Skip to content

Blink: use slices.Backward in PhpdocNoUselessInheritdoc #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Nov 9, 2026
Merged

Blink: use slices.Backward in PhpdocNoUselessInheritdoc #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions blink/internal/fixer/rules/phpdoc_no_useless_inheritdoc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package rules

import (
"slices"
"strings"

"github.com/ecsphp/ecs-src/blink/internal/token"
Expand Down Expand Up @@ -34,8 +35,8 @@ func (PhpdocNoUselessInheritdoc) Fix(s *tokens.Stream) bool {
}
// docs are in ascending order; fixing from the end keeps earlier indices valid
changed := false
for k := len(docs) - 1; k >= 0; k-- {
if inheritdocFixDoc(s, docs[k]) {
for _, doc := range slices.Backward(docs) {
if inheritdocFixDoc(s, doc) {
changed = true
}
}
Expand Down
Loading