Repository navigation
Blink: only drop inheritdoc where PHP-CS-Fixer does - #340
Merged
TomasVotruba merged 1 commit intoNov 9, 2026
Merged
Conversation
`PhpdocNoUselessInheritdoc` removed every `{@inheritdoc}`, but the PHP fixer
only removes it from the docblock before a class or interface that neither
extends nor implements, and from docblocks inside one that also uses no
trait. Walk classes the same way and leave every other docblock alone, so
an overriding method or property in a subclass keeps its tag.
Member
|
Thank you, looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhpdocNoUselessInheritdocremoved every{@inheritdoc}, but the PHP fixer only removes it from the docblock before a class or interface that neither extends nor implements, and from docblocks inside one that also uses no trait. Walk classes the same way and leave every other docblock alone, so an overriding method or property in a subclass keeps its tag.