Repository navigation
Blink: keep whitespace-only lines in NoTrailingWhitespace - #339
Merged
TomasVotruba merged 1 commit intoNov 9, 2026
Merged
TomasVotruba merged 1 commit into
TomasVotruba merged 1 commit into
Conversation
PHP-CS-Fixer trims a whitespace token only up to its first line break: the segments after it are pure whitespace, and it only rewrites a segment when trimming leaves something behind. A line holding nothing but spaces is therefore left alone, as is a trailing single-line run unless it ends the file. The Go port stripped every run before a newline, so it emptied those lines and reported files the PHP engine passes. Trim the same span PHP does, including its open-tag exception, and treat `\r\n` and a lone `\r` as line breaks as `\R` does.
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP-CS-Fixer trims a whitespace token only up to its first line break: the segments after it are pure whitespace, and it only rewrites a segment when trimming leaves something behind. A line holding nothing but spaces is therefore left alone, as is a trailing single-line run unless it ends the file. The Go port stripped every run before a newline, so it emptied those lines and reported files the PHP engine passes.
Trim the same span PHP does, including its open-tag exception, and treat
\r\nand a lone\ras line breaks as\Rdoes.