Repository navigation
Blink: dump the config of fixers that keep options in their own props - #338
Merged
TomasVotruba merged 1 commit intoNov 9, 2026
Conversation
`BlinkConfigDumper` read options only from the PHP-CS-Fixer `configuration`
property, so a fixer that stores them in its own properties dumped `{}`.
Symplify's `LineLengthFixer` is one: `inline_short_lines => false` was dropped
and ecs-go inlined every short multiline block. Fall back to the options the
fixer was configured with in `ecs.php`.
`ECSConfig` now registers itself in the container so the dumper reads the
resolved configuration rather than a freshly autowired, empty instance.
Member
|
Got it, thank you |
owenvoke
deleted the
blink-dump-fixer-config-without-configuration-property
branch
November 9, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlinkConfigDumperread options only from the PHP-CS-Fixerconfigurationproperty, so a fixer that stores them in its own properties dumped{}. Symplify'sLineLengthFixeris one:inline_short_lines => falsewas dropped and ecs-go inlined every short multiline block. Fall back to the options the fixer was configured with inecs.php.ECSConfignow registers itself in the container so the dumper reads the resolved configuration rather than a freshly autowired, empty instance.