Skip to content

Fix unified diff code mining cleanup and overlays - #3056

Merged
tobiasmelcher merged 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-mining-cleanup
Nov 9, 2026
Merged

tobiasmelcher merged 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-mining-cleanup

Conversation

@tobiasmelcher

@tobiasmelcher tobiasmelcher commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Unified-diff line-header code minings can retain stale vertical indentation when their annotations are removed before they are marked deleted. Mark annotations as deleted before removing them so the code-mining framework resets its layout state, and synchronize their cached drawing state with cleanup.

Click-through detailed-diff overlays can remain after hiding either one diff or all diffs, leaving them at an invalid location. Dispose all click-through overlays for the viewer whenever either hide action runs.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   36m 7s ⏱️ - 2m 26s
 5 005 tests +1   4 983 ✅ +1   22 💤 ±0  0 ❌ ±0 
12 906 runs  +3  12 752 ✅ +3  154 💤 ±0  0 ❌ ±0 

Results for commit 70745ad. ± Comparison against base commit bc125e3.

♻️ This comment has been updated with latest results.

@tobiasmelcher
tobiasmelcher force-pushed the d031119/unified-diff-mining-cleanup branch from ea64e31 to 70745ad Compare November 6, 2026 17:56
@tobiasmelcher tobiasmelcher changed the title Fix unified diff code mining cleanup Fix unified diff code mining cleanup and overlays Nov 6, 2026
@tobiasmelcher
tobiasmelcher merged commit 5cccf6a into eclipse-platform:master Nov 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant