Repository navigation
Conversation
ThemeEngine reset the widgets before telling the Display about the new theme. On GTK a null color resolves to the current system color, so controls without a rule in the new theme kept the colors of the old one, for example dark buttons and tables in Forms editors after switching from Dark to Light. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Test Results 867 files 867 suites 55m 42s ⏱️ Results for commit 4bd8b48. |
Contributor
Author
|
Before: 
Before switch to light: After: 
After: switch to light On Windows, PR 4557 fixes part of the Dark → Light switch problem, but not all of it. After the switch, the Forms section title bars and their titles look right again. Text fields, checkboxes, radio buttons and push buttons stay dark, and so does the background behind some section content. The remaining issues can be investigated and fixed via different PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThemeEngine reset the widgets before telling the Display about the new theme. On GTK a null color resolves to the current system color, so controls without a rule in the new theme kept the colors of the old one, for example dark buttons, tables and white label text in the PDE manifest editor after switching from Dark to Light. The preference is now set first, so a theme switch gives these controls the same colors as a freshly opened editor.