Repository navigation
Use pattern variables in the server event filter - #2128
Merged
kevinherron merged 1 commit intoOct 16, 2026
Merged
Conversation
EventContentFilter and MonitoredEventItem check a type with instanceof and then cast the same value again in six places, the form the "pattern variable can be used" cleanup in eclipse-milo#1440 did not pick up. Bind a pattern variable in the instanceof instead, next to the ElementOperand branch that already does. No behaviour change. I compared the bytecode of every method in both classes and their inner classes. The five changed methods differ only by the store and load of the new locals. With that undone they are the same, and all other methods are byte for byte identical. Signed-off-by: alxkm <alexanderklmn@gmail.com>
 |
Contributor
|
@alxkm I changed the base, we're back to targeting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #2092, #2102 and #2110, for the server event filter.
EventContentFilterandMonitoredEventItemcheck a type withinstanceofand then cast the same value again in six places, the form the #1440 inspection skipped. Each now binds a pattern variable, next to theElementOperandbranch that already does. 2 files, 12 lines.No behaviour change. I compared the bytecode of every method in both classes and their inner classes: the five changed methods differ only by the store and load of the new locals. With that undone they match, and every other method is byte for byte identical. mvn verify passes for sdk-server and the integration tests.