Repository navigation
Conversation
wolf4ood
force-pushed
the
test/6105_multi_replica_transfer_state_machine
branch
from
October 16, 2026 13:08
9f442d6 to
5addf0b
Compare
wolf4ood
marked this pull request as ready for review
October 16, 2026 13:43
paullatzelsperger
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
New
TransferProcessStateMachineMultiReplicaTest(transfer-process-store-sql,@ComponentTest, Postgres):TransferProcessManagerImplwithTransferProcessorsImpl) as replicas, each with its ownSqlTransferProcessStoreand lease holder, over the samedatabase. It uses the production
LocalTransactionContext, soFOR UPDATE SKIP LOCKEDapplies.TransferRequestMessageis sent exactly once across the replicas.Why it does that
The existing concurrency tests (
Sql*StoreConcurrencyTest) imitate the state machine with hand-written loops ofnextNotLeasedandsave. This test runs the real manager, processors and retry processor, so a change that breaksthe exactly-once processing between replicas (leasing, saving, lease release) is caught where it matters.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Relates to #6105
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.