Repository navigation
fix(engine): the events of a trace are read from <Events> - #82
Merged
Merged
Conversation
AMO writes a trace's events as <Events><Event>…</Event></Events> (Microsoft.AnalysisServices.Trace.Events, an [XmlArray] without a name), as ASSL names them; the model read them as <EventType>, so a trace from SQL Server Profiler or SSMS arrived without an event. Signed-off-by: dbulahov <bulahovdenis@gmail.com>
stbischof
force-pushed
the
main201026_1
branch
from
October 20, 2026 16:34
ba87a91 to
ef3b099
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AMO writes a trace's events as
<Events><Event>…</Event></Events>: the property isMicrosoft.AnalysisServices.Trace.Events, an[XmlArray]without a name of its own (AMO 19.114.12,Trace.cs), and ASSL names the element the same way. The engine model called the element of theTrace.eventTypereferenceEventType, so the reader skipped<Events>, and a trace from SQL Server Profiler or SSMS arrived without a single event.The change is one line in
model/engine/model/engine.ecore: the ExtendedMetaData name ofTrace.eventTypeisEventsinstead ofEventType. The classEventType, itsEventchildren and the Java names (getEventType()) stay as they are.