Repository navigation
fix(rowset): CATALOG_NAME is a required restriction of DISCOVER_CSDL_METADATA - #81
Merged
Merged
Conversation
…METADATA [MS-SSAS] marks it [Required], and both public SSAS servers refuse a request without it -- the Catalog property no stand-in -- with "XML for Analysis parser: The CATALOG_NAME restriction is required but is missing from the request." RestrictionsGuard reads the mark, so the transport and the embedded connector refuse the same way. The other fourteen restrictions the specification marks [Required] are marked already. Signed-off-by: dbulahov <bulahovdenis@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CATALOG_NAMEis a required restriction ofDISCOVER_CSDL_METADATA[MS-SSAS] marks
CATALOG_NAMEas [Required], and both public SSAS servers refuse a request without it; the Catalog property does not stand in for it:The change is one annotation,
required=true, oncatalogNameof the CSDL restrictions inrowset-server.ecore.RestrictionsGuardalready reads this mark for the other fourteen required restrictions, so the transport and the embedded connector now refuse the same way.