Repository navigation
Stop using reference equality for bytes match - #145
Merged
divarvel merged 1 commit intoOct 25, 2026
Merged
Conversation
The equals method on `byte[]` performs reference equality rather than structural equality. Instead just delegate to our own equals method, like `Term.Null` and `Term.Date` do. In the current library this check would incorrectly fail: ``` foo(hex:deadbeef); check if foo(hex:deadbeef); ```
divarvel
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The equals method on
byte[]performs reference equality rather than structural equality. Instead just delegate to our own equals method, likeTerm.NullandTerm.Datedo.In the current library this check would incorrectly fail: