Repository navigation
Feature #584 linkcheck_job - #590
Merged
Merged
Conversation
…ly with the documentation build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 23 tasks
jprestop
approved these changes
Oct 14, 2026
jprestop
left a comment
Contributor
There was a problem hiding this comment.
I approve this PR to break out the Check Links in a new job in the documentation workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Describe the changes proposed by this pull request:
Closes #584
Runs the link checker as its own Check Links job in the Documentation workflow, concurrently with the docs build. This is the same change made in METplus (dtcenter/METplus#3359, dtcenter/METplus@0db2fb2). Before, Check links was the last step of the Build Documentation job.
.github/workflows/documentation.yaml, the newlinkcheckjob checks out the repository and runsdtcenter/metplus-action-linkcheck@v1with the same inputs as before. The action sets up Python and installs the docs requirements itself, so the job needs no other steps.Pull Request Testing
Describe testing already performed for these changes:
Confirmed that the updated workflow file parses as YAML and defines separate
documentationandlinkcheckjobs. The Documentation workflow run on this PR tests the change itself.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Confirm that the Documentation workflow on this PR shows separate Build Documentation and Check Links jobs, and review the Linkcheck Results in the Check Links job summary.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] No documentation changes are needed.
Do these changes include sufficient testing updates? [Yes] No testing changes are needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases and/or METplus-X.Y Development project for the next coordinated release
🤖 Generated with Claude Code