Fix zero retry limits being ignored when cloning clients - #607
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning a client with
max_retries_on_error=0ormax_retries_on_rate_limit=0currently retains the original retry limit becauseclone()uses truthiness to choose defaults. For example, cloning a client with a limit of 2 still makes three requests after explicitly disabling retries.Use an explicit
Nonecheck for both retry settings so zero disables retries while omitted values retain the original limits. The regression tests exercise the retry loop for server errors and rate limits, check that it does not sleep, and verify that the original client and default clones retain their settings.Validation: both regression cases failed before the fix; all 102 unit tests pass on Python 3.13 afterward. Ruff lint and formatting checks pass. Live API integration tests were not run.