Repository navigation
Fix InvalidCastException for nullable enum parameter default values i… - #69918
Open
AnsElgyarDev wants to merge 1 commit into
Open
AnsElgyarDev wants to merge 1 commit into
AnsElgyarDev wants to merge 1 commit into
Conversation
AnsElgyarDev
requested review from
a team,
Youssef1313,
cincuranet,
davpetr and
rokonec
as code owners
October 18, 2026 15:27
Contributor
|
Thanks for your PR, @AnsElgyarDev. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
1 task done
Author
|
The only failing check is "Local development validation / Test: Windows local development validation / Build (No NodeJS)". The log shows RZ1021 errors in src/Components/test/testassets/Components.TestServer Razor files, which are unrelated to this change (it only touches Microsoft.AspNetCore.OpenApi and its tests). All Microsoft.AspNetCore.OpenApi.Tests pass locally. Could a maintainer re-run it if needed? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69864
Description
ParameterInfo.DefaultValuereturns the underlying integral value (a boxedInt32) forNullable<TEnum>parameters rather than aTEnum.ApplyParameterInfopassed that value toApplyDefaultValue, which serialized it using theJsonTypeInfoforTEnum?, causing anInvalidCastExceptionduring OpenAPI document generation.This converts the default value with
Enum.ToObjectbefore applying it, matching whatParameterDefaultValue.TryGetDefaultValueandRequestDelegateFactoryalready do for nullable enums.Tests
Status? = Status.Pending,TaskStatus? = TaskStatus.CanceledandStatus? = nullcases toRouteParametersWithDefaultValues.[FromBody]nullable enum parameter with a default value.InvalidCastExceptionfrom the issue. With the fix, allMicrosoft.AspNetCore.OpenApi.Testspass.MVC actions go through the same
ApplyParameterInfocode path, but I did not add a dedicated MVC test.