Repository navigation
Clear redirected SignalR access tokens before restarting negotiation - #69916
Closed
fredrikbernholm wants to merge 1 commit into
Closed
fredrikbernholm wants to merge 1 commit into
fredrikbernholm wants to merge 1 commit into
Conversation
fredrikbernholm
requested review from
BrennanConroy and
halter73
as code owners
October 18, 2026 14:01
Contributor
|
Thanks for your PR, @fredrikbernholm. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Closed
1 task done
Author
|
Replaced with bug report #69917 so the issue can be triaged before proposing a change. |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cookie-authenticated client that negotiates through an Azure SignalR redirect can connect once but fail every automatic reconnect. The cached bearer token from the service redirect survives the next
HttpConnection.start(), so the client sends that service token to the original application's negotiate endpoint even though no applicationaccessTokenFactoryis configured.Clear the cached HTTP token when a connection starts, alongside restoring the application's token factory. The original endpoint can then use cookie authentication again, and the redirected service receives its newly negotiated token.
The regression starts, stops and restarts a connection with a negotiate redirect, checking the Authorization header at both endpoints. It fails on current main before the fix. All 84
HttpConnectiontests pass with the fix, and the touched test file passes ESLint.Also reproduced against a live Azure SignalR deployment with client 9.0.6: the initial connection and group subscription succeeded, but terminating the WebSocket caused subsequent application negotiations to return 404 with the service bearer token attached. Clearing the cache restored negotiation, automatic reconnect, group rejoining and backend push delivery. A released-client regression also fails before the fix and passes afterward.