Repository navigation
Conversation
Contributor
|
Thanks for your PR, @SENESO. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66434 (also closes #69061 as a duplicate).
RateLimitingMiddlewarecreates its ownPartitionedRateLimiter<HttpContext>(_endpointLimiter) inCreateEndpointLimiter()but never disposes it. The limiter's internal timer infrastructure keeps the host rooted, so everyWebApplicationFactory-based test class leaks roughly one host (~100MB). Verified with aWeakReferencerepro: the host is not collectable withUseRateLimiterbefore this change, and collectable after.The fix registers the middleware-owned limiter for disposal on
IHostApplicationLifetime.ApplicationStopped. Design notes:_endpointLimiteris disposed — it is created inside the middleware, so the middleware is its sole owner._globalLimitercomes fromRateLimiterOptions.GlobalLimiter(user-provided) and is deliberately left alone: the user may share it across hosts or dispose it themselves.GetService(notGetRequiredService) keeps this null-safe for non-host scenarios; the callback is astaticlambda so the registration can't root the middleware instance.Tests:
EndpointLimiterIsDisposedWhenApplicationStops— fails without the fix, passes with it.GlobalLimiterIsNotDisposedWhenApplicationStops— documents the ownership decision.Note: I couldn't execute the repo's own test suite in my environment (it needs the source-built targeting pack from a near-full repo build), so CI is the real gate here. The change is minimal, additive, and null-safe.