Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ResolverService RPC to allow clients to set secrets into the keychain.
Changes:
- Introduces
SetSecretRPC onResolverServicein the protobuf API. - Wires
SetSecretthrough the Connect client/server glue code (procedure constant, client method, handler route, unimplemented stub). - Regenerates Go protobuf/Connect artifacts to include the new RPC and message types.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| x/api/resolver/v1/resolverv1connect/api.connect.go | Adds Connect procedure/client/handler plumbing for the new SetSecret RPC. |
| x/api/resolver/v1/api.proto | Defines the new SetSecret RPC and request/response messages. |
| x/api/resolver/v1/api.pb.go | Regenerated protobuf Go output reflecting the new RPC/messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
secrets/endpoint
branch
from
February 10, 2026 14:22
6b197c8 to
268f407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows secrets engine to set secrets on behalf of a client into the keychain.