Repository navigation
Add java.lang.ref weak references, Timer date fixed-rate scheduling, and index exception int constructors - #241
Merged
Merged
Conversation
…on overloads - java.lang.ref.Reference and WeakReference; the garbage collector no longer traces Reference.referent and clears it once the referent is otherwise unreachable - Timer.scheduleAtFixedRate(TimerTask, Date, long) - ArrayIndexOutOfBoundsException(int) and StringIndexOutOfBoundsException(int)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 87.84% 87.87% +0.02%
==========================================
Files 311 313 +2
Lines 47183 47315 +132
==========================================
+ Hits 41448 41576 +128
- Misses 5735 5739 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.lang.ref
java.lang.ref.Reference(get(),clear()) andjava.lang.ref.WeakReference(WeakReference(Object)).Reference.referent, and clears it on reachable references once the referent is no longer strongly reachable.Timer
Timer.scheduleAtFixedRate(TimerTask, Date, long), with the same validation asschedule(TimerTask, Date, long).Index exceptions
ArrayIndexOutOfBoundsException(int)andStringIndexOutOfBoundsException(int), producingArray index out of range: <index>andString index out of range: <index>.Verification
WeakReferenceSemanticsfixture run bytest_class, with expected output generated on a real JVM; it fails without the collector change.cargo fmt --check,cargo clippy --workspace --all-targets, andcargo test --workspacepass.