Skip to content

Issue #365: Serialization order of features does not match Java implementation - #366

Merged
reckart merged 1 commit into
mainfrom
bugfix/365-Serialization-order-of-features-does-not-match-Java-implementation
Sep 19, 2026
Merged

reckart merged 1 commit into
mainfrom
bugfix/365-Serialization-order-of-features-does-not-match-Java-implementation

Conversation

@reckart

@reckart reckart commented Sep 19, 2026

Copy link
Copy Markdown
Member

What's in the PR

  • Return inherited features before own features in Type.all_features, matching the order of UIMA's TypeImpl (supertype chain top-down, then features introduced by the type itself)
  • Make JSON and XMI serializer output byte-compatible with the UIMA Java reference implementation, so an unedited read/write round-trip no longer reorders the keys of every feature structure
  • Document the guaranteed feature order on all_features, since the serializers now rely on it
  • Update the all-features ordering assertion for features added to a parent after the child type exists

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…mentation

- Return inherited features before own features in `Type.all_features`, matching the order of UIMA's `TypeImpl` (supertype chain top-down, then features introduced by the type itself)
- Make JSON and XMI serializer output byte-compatible with the UIMA Java reference implementation, so an unedited read/write round-trip no longer reorders the keys of every feature structure
- Document the guaranteed feature order on `all_features`, since the serializers now rely on it
- Update the all-features ordering assertion for features added to a parent after the child type exists
@reckart reckart added this to the 0.12.0 milestone Sep 19, 2026
@reckart reckart self-assigned this Sep 19, 2026
@reckart reckart added this to Kanban Sep 19, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Kanban Sep 19, 2026
@reckart
reckart merged commit 1c06233 into main Sep 19, 2026
5 checks passed
@reckart
reckart deleted the bugfix/365-Serialization-order-of-features-does-not-match-Java-implementation branch September 19, 2026 11:15
@github-project-automation github-project-automation Bot moved this from In progress to Done in Kanban Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant