Repository navigation
Coordinator: a dictation the processors empty leaves the last transcript as it was - #74
Merged
Merged
Conversation
…ipt as it was Pins the behaviour #73 asked to confirm: the menu's "Last" line keeps the previous dictation instead of showing the engine's raw text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #73, point 7.
The issue asked whether a dictation the processors reduce to nothing (fillers only, say) should leave the previous "Last: …" menu line. Decision: keep it. This PR pins that behaviour with a test and changes no production code.
What
aDictationTheProcessorsEmptyLeavesTheLastTranscriptAlonedictates once with a dictionary rule that turns the engine's "hello world" into "first", then changes the rule to empty the same text and dictates again. The second dictation pastes nothing, the coordinator goes back to idle, andlastTranscriptis still "first".The first dictation's processed text is deliberately different from the engine's raw text. Otherwise the test could not tell "kept the previous one" from "showed the raw text".
Verified
lastTranscript = transcriptput back before the pipeline (the old raw assignment), the test fails onlastTranscript?.text == "first".swift buildandswift test(602 tests) green.docs/ARCHITECTURE.md, "Dictation flow", step 3 already says it plainly ("a dictation the processors empty pastes nothing and leaves it as it was"), so the docs are unchanged.Not on the release path: test only.
🤖 Generated with Claude Code