Repository navigation
Conversation
This was referenced Oct 22, 2026
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 2fb2aab | Previous: c3f0add | Ratio |
|---|---|---|---|
peak memory |
1780.062 MB |
1762.234 MB |
1.01 |
peak threads |
356 threads |
359 threads |
0.99 |
network (transport) |
2730.958 MB |
2735.794 MB |
1.00 |
disk write |
1.793 MB |
1.699 MB |
1.06 |
instructions |
137.571 G |
137.654 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why do we need this?
An operator should be able to activate SONIC, stop a navigation command without dropping balance, and request damping from Desktop. The Controller app must act on the run the operator inspected, not a replacement run.
What is this feature?
Stack: #4304 -> #4305 -> #3557 -> #4783 -> #4784.
Layer 4, based on #3557. 9 files, +220/-2 relative to that base.
G1SonicPolicyModule.activate(): validate feedback, clocks and ramp, then request live measured-pose activation in one operation.stop_motion()and MovementManager stop/status RPCs. Stop motion cancels navigation and operator references while balancing continues.run_id, rejecting a replaced run. No new controller or motor-command publisher.The UI is a companion change in jeff-hykin/dim-controller#1. This PR has no sim2, ControlCoordinator or Pico implementation.
How to manually run this
On macOS or a CUDA-enabled Linux host with SONIC dependencies installed:
Open Desktop's Controller app with the companion frontend branch. Inspect the SONIC panel, drive with the existing controls, click Stop motion and confirm walking stops but balancing continues. Exercise Deactivate/Activate with the robot supported in simulation, then Damping stop. Damping is latched until restart, not a physical power disconnect. Hardware starts unarmed; the existing sim automatically activates.
macOS simulation selects CPU inference automatically. Install with
uv sync --extra control --extra simon a Mac. Real hardware still requires CUDA and rejects the CPU-simulation option. See sonic-desktop.md.Verification
Which issue(s) does this PR close?
Follow-up to #3557; no separate issue closed.
Checklist