Repository navigation
fix: resolve native sources for pip installations - #3970
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3970 +/- ##
==========================================
+ Coverage 80.08% 80.12% +0.03%
==========================================
Files 1611 1612 +1
Lines 151456 151694 +238
Branches 12841 12855 +14
==========================================
+ Hits 121294 121541 +247
+ Misses 26601 26594 -7
+ Partials 3561 3559 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. |
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 9d93ef7 | Previous: faf1bed | Ratio |
|---|---|---|---|
peak memory |
1571.949 MB |
1616.949 MB |
0.97 |
peak threads |
395 threads |
402 threads |
0.98 |
network (transport) |
2732.688 MB |
2738.458 MB |
1.00 |
disk write |
1.617 MB |
1.598 MB |
1.01 |
instructions |
124.645 G |
124.651 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
TomCC7
commented
Oct 5, 2026
TomCC7
force-pushed
the
cc/fix/native-mcap-tools
branch
from
October 6, 2026 03:41
0982249 to
c9f7428
Compare
TomCC7
commented
Oct 6, 2026
TomCC7
commented
Oct 6, 2026
TomCC7
commented
Oct 6, 2026
TomCC7
marked this pull request as ready for review
October 6, 2026 07:04
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
October 6, 2026 07:04
paul-nechifor
previously approved these changes
Oct 7, 2026
TomCC7
force-pushed
the
cc/fix/rust-recorder-chore
branch
from
October 7, 2026 02:33
5fa504e to
c0118ac
Compare
TomCC7
enabled auto-merge (squash)
October 7, 2026 02:58
paul-nechifor
previously approved these changes
Oct 7, 2026
auto-merge was automatically disabled
October 7, 2026 03:44
Pull request was closed
TomCC7
enabled auto-merge (squash)
October 7, 2026 03:49
paul-nechifor
approved these changes
Oct 7, 2026
paul-nechifor
disabled auto-merge
October 7, 2026 06:18
jeff-hykin
pushed a commit
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
source_dirand relativeexecutable. Build and run from that source directory.cwd; old arguments raise a migration error. External binaries usesource_dir=Noneandbuild_command=None, anchor relative executable paths at initialization, and run from the executable directory without fetching sources.get_project_root(): use the development checkout, or clonemainonce under a file lock and reuse it without automatic updates. The cached revision can differ from the installed package.